linux-kernel - Re: [PATCH 10/23] wireless: remove unnecessary unlikely()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87va7qdfry.fsf@kamboji.qca.qualcomm.com>
Date:   Fri, 31 Aug 2018 12:52:33 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Igor Stoppa <igor.stoppa@...il.com>
Cc:     linux-kernel@...r.kernel.org, Igor Stoppa <igor.stoppa@...wei.com>,
        Christian Lamparter <chunkeey@...glemail.com>,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH 10/23] wireless: remove unnecessary unlikely()

+ linux-wireless

Igor Stoppa <igor.stoppa@...il.com> writes:

> WARN_ON_ONCE() already contains an unlikely(), and the logical or of two of
> them is still unlikely(), so it's not necessary to wrap them into another.
>
> Signed-off-by: Igor Stoppa <igor.stoppa@...wei.com>
> Cc: Christian Lamparter <chunkeey@...glemail.com>
> Cc: Kalle Valo <kvalo@...eaurora.org>

IMHO you could fold patches 10, 11 and 12 into one to avoid having three
patches with duplicate titles. Or alternatively use proper driver
prefixes like "ath10k:", "b43:" and so on.

But how do you want these to be applied? For the wireless patches you
didn't Cc linux-wireless so our patchwork won't see them and hence I
can't take them. So if you want me to take these, please resend and
include linux-wireless.

-- 
Kalle Valo