lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 Sep 2018 13:58:09 -0700 From: Bjorn Andersson <bjorn.andersson@...aro.org> To: Stephen Boyd <swboyd@...omium.org> Cc: Linus Walleij <linus.walleij@...aro.org>, linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, linux-arm-msm@...r.kernel.org, Doug Anderson <dianders@...omium.org> Subject: Re: [PATCH] pinctrl: qcom: spmi-mpp: Fix drive strength setting On Thu 30 Aug 17:58 PDT 2018, Stephen Boyd wrote: > It looks like we parse the drive strength setting here, but never > actually write it into the hardware to update it. Parse the setting and > then write it at the end of the pinconf setting function so that it > actually sticks in the hardware. > > Fixes: 0e948042c420 ("pinctrl: qcom: spmi-mpp: Implement support for sink mode") > Cc: Bjorn Andersson <bjorn.andersson@...aro.org> > Cc: Doug Anderson <dianders@...omium.org> > Signed-off-by: Stephen Boyd <swboyd@...omium.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org> Regards, Bjorn > --- > drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c > index 6556dbeae65e..1793a4d05e15 100644 > --- a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c > @@ -455,7 +455,7 @@ static int pmic_mpp_config_set(struct pinctrl_dev *pctldev, unsigned int pin, > pad->dtest = arg; > break; > case PIN_CONFIG_DRIVE_STRENGTH: > - arg = pad->drive_strength; > + pad->drive_strength = arg; > break; > case PMIC_MPP_CONF_AMUX_ROUTE: > if (arg >= PMIC_MPP_AMUX_ROUTE_ABUS4) > @@ -502,6 +502,10 @@ static int pmic_mpp_config_set(struct pinctrl_dev *pctldev, unsigned int pin, > if (ret < 0) > return ret; > > + ret = pmic_mpp_write(state, pad, PMIC_MPP_REG_SINK_CTL, pad->drive_strength); > + if (ret < 0) > + return ret; > + > val = pad->is_enabled << PMIC_MPP_REG_MASTER_EN_SHIFT; > > return pmic_mpp_write(state, pad, PMIC_MPP_REG_EN_CTL, val); > -- > Sent by a computer through tubes >
Powered by blists - more mailing lists