linux-kernel - RE: [PATCH rdma-next] RDMA/qedr: remove set but not used variable 'ctx'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 3 Sep 2018 09:22:49 +0000
From:   "Verma, Rahul" <Rahul.Verma@...ium.com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "Kalderon, Michal" <Michal.Kalderon@...ium.com>,
        "Elior, Ariel" <Ariel.Elior@...ium.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>
CC:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH rdma-next] RDMA/qedr: remove set but not used variable
 'ctx'


> -----Original Message-----
> From: YueHaibing <yuehaibing@...wei.com>
> Sent: Saturday, September 1, 2018 6:54 AM
> To: Kalderon, Michal <Michal.Kalderon@...ium.com>; Elior, Ariel
> <Ariel.Elior@...ium.com>; Doug Ledford <dledford@...hat.com>; Jason
> Gunthorpe <jgg@...pe.ca>
> Cc: YueHaibing <yuehaibing@...wei.com>; linux-rdma@...r.kernel.org;
> linux-kernel@...r.kernel.org; kernel-janitors@...r.kernel.org
> Subject: [PATCH rdma-next] RDMA/qedr: remove set but not used variable
> 'ctx'
>
> External Email
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/infiniband/hw/qedr/verbs.c: In function 'qedr_create_srq':
> drivers/infiniband/hw/qedr/verbs.c:1450:24: warning:
>  variable 'ctx' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/infiniband/hw/qedr/verbs.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/qedr/verbs.c
> b/drivers/infiniband/hw/qedr/verbs.c
> index 8cc3df2..9d4d165 100644
> --- a/drivers/infiniband/hw/qedr/verbs.c
> +++ b/drivers/infiniband/hw/qedr/verbs.c
> @@ -1447,7 +1447,6 @@ struct ib_srq *qedr_create_srq(struct ib_pd
> *ibpd,
>         u64 pbl_base_addr, phy_prod_pair_addr;
>         struct ib_ucontext *ib_ctx = NULL;
>         struct qedr_srq_hwq_info *hw_srq;
> -       struct qedr_ucontext *ctx = NULL;
>         u32 page_cnt, page_size;
>         struct qedr_srq *srq;
>         int rc = 0;
> @@ -1473,7 +1472,6 @@ struct ib_srq *qedr_create_srq(struct ib_pd
> *ibpd,
>
>         if (udata && ibpd->uobject && ibpd->uobject->context) {
>                 ib_ctx = ibpd->uobject->context;
> -               ctx = get_qedr_ucontext(ib_ctx);
>
>                 if (ib_copy_from_udata(&ureq, udata, sizeof(ureq))) {
>                         DP_ERR(dev,

Thank Yue.
Acked-by: Rahul Verma <rahul.verma@...ium.com>