linux-kernel - Re: [PATCH v2 15/34] ARM: tegra: apalis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180903092228.7k46uf6qehgou5wx@holly.lan>
Date:   Mon, 3 Sep 2018 10:22:28 +0100
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Marcel Ziswiler <marcel@...wiler.com>
Cc:     devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v2 15/34] ARM: tegra: apalis_t30: reorder backlight
 properties

On Fri, Aug 31, 2018 at 06:37:57PM +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> 
> Reorder backlight properties.

This is a bit terse. Should the header explain why too?


> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> 
> ---
> 
> Changes in v2: None
> 
>  arch/arm/boot/dts/tegra30-apalis-eval.dts | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra30-apalis-eval.dts b/arch/arm/boot/dts/tegra30-apalis-eval.dts
> index 9f2392a05532..300ce726ff4d 100644
> --- a/arch/arm/boot/dts/tegra30-apalis-eval.dts
> +++ b/arch/arm/boot/dts/tegra30-apalis-eval.dts
> @@ -185,13 +185,12 @@
>  
>  	backlight: backlight {
>  		compatible = "pwm-backlight";
> -		/* PWM_BKL1 */
> -		pwms = <&pwm 0 5000000>;
>  		brightness-levels = <255 231 223 207 191 159 127 0>;
>  		default-brightness-level = <6>;
>  		/* BKL1_ON */
>  		enable-gpios = <&gpio TEGRA_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
>  		power-supply = <&reg_3v3>;
> +		pwms = <&pwm 0 5000000>; /* BKL1_PWM */
>  	};
>  
>  	gpio-keys {
> -- 
> 2.14.4
>