linux-kernel - Re: [PATCH v2 15/34] ARM: tegra: apalis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1535975421.14464.2.camel@toradex.com>
Date:   Mon, 3 Sep 2018 11:50:23 +0000
From:   Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:     "daniel.thompson@...aro.org" <daniel.thompson@...aro.org>
CC:     "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "jonathanh@...dia.com" <jonathanh@...dia.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Subject: Re: [PATCH v2 15/34] ARM: tegra: apalis_t30: reorder backlight
 properties

On Mon, 2018-09-03 at 10:22 +0100, Daniel Thompson wrote:
> On Fri, Aug 31, 2018 at 06:37:57PM +0200, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> > 
> > Reorder backlight properties.
> 
> This is a bit terse. Should the header explain why too?

I agree. I guess I missed mentioning it here explicitly. At other
places I did usually mentioned that it improves the situation in
regards to all our other device trees. It's just a pain to look at
various device trees if stuff is randomly ordered.

> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> > 
> > ---
> > 
> > Changes in v2: None
> > 
> >  arch/arm/boot/dts/tegra30-apalis-eval.dts | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/tegra30-apalis-eval.dts
> > b/arch/arm/boot/dts/tegra30-apalis-eval.dts
> > index 9f2392a05532..300ce726ff4d 100644
> > --- a/arch/arm/boot/dts/tegra30-apalis-eval.dts
> > +++ b/arch/arm/boot/dts/tegra30-apalis-eval.dts
> > @@ -185,13 +185,12 @@
> >  
> >  	backlight: backlight {
> >  		compatible = "pwm-backlight";
> > -		/* PWM_BKL1 */
> > -		pwms = <&pwm 0 5000000>;
> >  		brightness-levels = <255 231 223 207 191 159 127
> > 0>;
> >  		default-brightness-level = <6>;
> >  		/* BKL1_ON */
> >  		enable-gpios = <&gpio TEGRA_GPIO(V, 2)
> > GPIO_ACTIVE_HIGH>;
> >  		power-supply = <&reg_3v3>;
> > +		pwms = <&pwm 0 5000000>; /* BKL1_PWM */
> >  	};
> >  
> >  	gpio-keys {
> > -- 
> > 2.14.4