linux-kernel - Re: [PATCH] i2c: xiic: Make the start and the byte count write atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180904161114.GC5000@kunai>
Date:   Tue, 4 Sep 2018 18:11:14 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     shubhrajyoti.datta@...il.com
Cc:     linux-i2c@...r.kernel.org, michal.simek@...inx.com,
        linux-kernel@...r.kernel.org,
        Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
Subject: Re: [PATCH] i2c: xiic: Make the start and the byte count write atomic

On Mon, Sep 03, 2018 at 03:11:11PM +0530, shubhrajyoti.datta@...il.com wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
> 
> Disable interrupts while configuring the transfer and enable them back.
> 
> We have below as the programming sequence
> 1. start and slave address
> 2. byte count and stop
> 
> In some customer platform there was a lot of interrupts between 1 and 2
> and after slave address (around 7 clock cyles) if 2 is not executed
> then the transaction is nacked.
> 
> To fix this case make the 2 writes atomic.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>

I assume simply changing the order of the register writes won't fix it?

I also assume this is stable material?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)