linux-kernel - Re: [PATCH] ethernet: hnae: add unlikely() to assert()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180907.144659.284526279757617907.davem@davemloft.net>
Date:   Fri, 07 Sep 2018 14:46:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     igor.stoppa@...il.com
Cc:     huangdaode@...ilicon.com, igor.stoppa@...wei.com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ethernet: hnae: add unlikely() to assert()

From: Igor Stoppa <igor.stoppa@...il.com>
Date: Fri,  7 Sep 2018 20:26:50 +0300

> The assert() condition is likely to be true.

Worse than that is that drivers should not be definiting their own
private "assert()" macro.

I'd rather have that fixed instead.  We have tons of standard kernel
facilities that do what they are trying to do here, without overloading
the standard C namespace in this way.