linux-kernel - Re: [PATCH] ethernet: hnae: add unlikely() to assert()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aaa1a5f7-6809-794b-f6e6-b5b2ae34b046@gmail.com>
Date:   Sat, 8 Sep 2018 18:00:27 +0300
From:   Igor Stoppa <igor.stoppa@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     huangdaode@...ilicon.com, igor.stoppa@...wei.com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ethernet: hnae: add unlikely() to assert()



On 08/09/18 00:46, David Miller wrote:
> From: Igor Stoppa <igor.stoppa@...il.com>
> Date: Fri,  7 Sep 2018 20:26:50 +0300
> 
>> The assert() condition is likely to be true.
> 
> Worse than that is that drivers should not be definiting their own
> private "assert()" macro.
> 
> I'd rather have that fixed instead.  We have tons of standard kernel
> facilities that do what they are trying to do here, without overloading
> the standard C namespace in this way.

I've converted into WARN() what passed the compile test.
In one case it didn't even compile :-(

I could only compile-test.

--
igor