linux-kernel - Re: [PATCH] i2c: xiic: Make the start and the byte count write atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a26d5aa1-de79-c881-da3c-5be67d1fc4a4@xilinx.com>
Date:   Fri, 7 Sep 2018 08:02:50 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Wolfram Sang <wsa@...-dreams.de>, <shubhrajyoti.datta@...il.com>
CC:     <linux-i2c@...r.kernel.org>, <michal.simek@...inx.com>,
        <linux-kernel@...r.kernel.org>,
        Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
Subject: Re: [PATCH] i2c: xiic: Make the start and the byte count write atomic

On 6.9.2018 20:52, Wolfram Sang wrote:
> On Mon, Sep 03, 2018 at 03:11:11PM +0530, shubhrajyoti.datta@...il.com wrote:
>> From: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
>>
>> Disable interrupts while configuring the transfer and enable them back.
>>
>> We have below as the programming sequence
>> 1. start and slave address
>> 2. byte count and stop
>>
>> In some customer platform there was a lot of interrupts between 1 and 2
>> and after slave address (around 7 clock cyles) if 2 is not executed
>> then the transaction is nacked.
>>
>> To fix this case make the 2 writes atomic.
>>
>> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
>> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> 
> Added a newline for better readability, added the stable tag and applied
> to for-current, thanks!
> 
> BTW we have no maintainer for this driver. Would you or Michal be
> interested in doing that? I don't maintain the whole driver directory
> anymore.

Normally we do handle it via Zynq fragment to have single point of
contact. I have sent a patch for that. Please take it via i2c tree.

Thanks,
Michal