linux-kernel - Re: [PATCH v8 1/2] leds: core: Introduce LED pattern trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180910212051.GB4697@amd>
Date:   Mon, 10 Sep 2018 23:20:51 +0200
From:   Pavel Machek <pavel@....cz>
To:     Baolin Wang <baolin.wang@...aro.org>
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        rteysseyre@...il.com, Mark Brown <broonie@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 1/2] leds: core: Introduce LED pattern trigger

Hi!

> >> I'm still convinced that this will confuse our users and to me it would
> >> be more logical if this denotes the number of times the pattern should
> >> be repeated, with e.g. negative numbers denoting infinite.
> >
> > Sounds reasonable. Let's change this semantics as you propose.
> >
> >> In particular I expect to have to explain why my driver expects that you
> >> write 0 in the file named "repeat" to make it repeat and 1 to make it
> >> not repeat.
> 
> Hm, so there are some cases we need to make clear.
> 1) If negative numbers present infinite, so what's the meaning of number 0?
> 2) What we should show for users if repeat number is negative, just
> show negative numbers or one string "infinite"?

I'd say just -1 is infinite, anything else is error.

And yes, reading it should just display -1.

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)