linux-kernel - Re: [PATCH v8 1/2] leds: core: Introduce LED pattern trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Sep 2018 09:22:25 +0800
From:   Baolin Wang <baolin.wang@...aro.org>
To:     Pavel Machek <pavel@....cz>
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        rteysseyre@...il.com, Mark Brown <broonie@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 1/2] leds: core: Introduce LED pattern trigger

On 11 September 2018 at 05:20, Pavel Machek <pavel@....cz> wrote:
> Hi!
>
>> >> I'm still convinced that this will confuse our users and to me it would
>> >> be more logical if this denotes the number of times the pattern should
>> >> be repeated, with e.g. negative numbers denoting infinite.
>> >
>> > Sounds reasonable. Let's change this semantics as you propose.
>> >
>> >> In particular I expect to have to explain why my driver expects that you
>> >> write 0 in the file named "repeat" to make it repeat and 1 to make it
>> >> not repeat.
>>
>> Hm, so there are some cases we need to make clear.
>> 1) If negative numbers present infinite, so what's the meaning of number 0?
>> 2) What we should show for users if repeat number is negative, just
>> show negative numbers or one string "infinite"?
>
> I'd say just -1 is infinite, anything else is error.
>
> And yes, reading it should just display -1.

OK. Thanks.

-- 
Baolin Wang
Best Regards