linux-kernel - Re: [PATCH] error-injection: remove meaningless null pointer check before debugfs_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5B9621D8.2030408@huawei.com>
Date:   Mon, 10 Sep 2018 15:48:40 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
CC:     <mhiramat@...nel.org>, <daniel@...earbox.net>,
        <tglx@...utronix.de>, <naveen.n.rao@...ux.vnet.ibm.com>,
        <jbacik@...com>, <keescook@...omium.org>, <ast@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] error-injection: remove meaningless null pointer check
 before debugfs_remove_recursive

On 2018/9/10 15:21, Ingo Molnar wrote:
> * zhong jiang <zhongjiang@...wei.com> wrote:
>
>> debugfs_remove_recursive has taken the null pointer into account.
>> just remove the null check before debugfs_remove_recursive.
>>
>> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
>> ---
>>  kernel/fail_function.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/kernel/fail_function.c b/kernel/fail_function.c
>> index bc80a4e..17f75b5 100644
>> --- a/kernel/fail_function.c
>> +++ b/kernel/fail_function.c
>> @@ -173,8 +173,7 @@ static void fei_debugfs_remove_attr(struct fei_attr *attr)
>>  	struct dentry *dir;
>>  
>>  	dir = debugfs_lookup(attr->kp.symbol_name, fei_debugfs_dir);
>> -	if (dir)
>> -		debugfs_remove_recursive(dir);
>> +	debugfs_remove_recursive(dir);
>>  }
>>  
>>  static int fei_kprobe_handler(struct kprobe *kp, struct pt_regs *regs)
> Please Cc: such patches to lkml and akpm.
 Ok, will do.
> Thanks,
>
> 	Ingo
>
>