linux-kernel - Re: [PATCH 0/4] staging: comedi: Correct multiline dereference as per TODO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180910083322.GA29149@kroah.com>
Date:   Mon, 10 Sep 2018 10:33:22 +0200
From:   Greg Kroah-Hartman <greg@...ah.com>
To:     Ray Clinton <mr.ray.clinton@...il.com>
Cc:     abbotti@....co.uk, hsweeten@...ionengravers.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] staging: comedi: Correct multiline dereference as
 per TODO

On Thu, Aug 30, 2018 at 01:32:09PM -0400, Ray Clinton wrote:
> Hi,
> 
> I've been working on the correcting the checkpatch.pl failures found in
> staging/drivers/staging/comedi of 4.18.0 and have a few patches to submit
> for review.
> 
> The files that I changed are:
> 
> drivers/dt3000.c
> drivers/ni_labpc_common.c
> drivers/ni_mio_common.c
> drivers/dt3000.c
> 
> While there were a few warnings/checks checkpatch.pl brings up the only
> one that the Internet told me was ok to work on were dereferences that
> happened over multiple lines. For each of the files above that was the issue
> and it was always due to the author trying to stay within the 80 character
> line width limitation. I did my best to remove the warning while keeping the
> code readable.
> 
> **PLEASE**: any feedback on what I could do better in the patches, in the
> emails, anything, would be much appreciated.

You sent 4 patches with the identical Subject: line, which isn't
something that I can apply.  Please make the subjects unique, as they
all do unique things, right?

thanks,

greg k-h