lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 30 Aug 2018 13:32:09 -0400
From:   Ray Clinton <mr.ray.clinton@...il.com>
To:     Greg Kroah-Hartman <greg@...ah.com>
Cc:     abbotti@....co.uk, hsweeten@...ionengravers.com,
        linux-kernel@...r.kernel.org
Subject: [PATCH 0/4] staging: comedi: Correct multiline dereference as per TODO

Hi,

I've been working on the correcting the checkpatch.pl failures found in
staging/drivers/staging/comedi of 4.18.0 and have a few patches to submit
for review.

The files that I changed are:

drivers/dt3000.c
drivers/ni_labpc_common.c
drivers/ni_mio_common.c
drivers/dt3000.c

While there were a few warnings/checks checkpatch.pl brings up the only
one that the Internet told me was ok to work on were dereferences that
happened over multiple lines. For each of the files above that was the issue
and it was always due to the author trying to stay within the 80 character
line width limitation. I did my best to remove the warning while keeping the
code readable.

**PLEASE**: any feedback on what I could do better in the patches, in the
emails, anything, would be much appreciated.

Thanks so much!

Ray

---

 drivers/staging/comedi/drivers/dt3000.c          | 6 +++---
 drivers/staging/comedi/drivers/ni_labpc_common.c | 8 ++++----
 drivers/staging/comedi/drivers/ni_mio_common.c   | 6 +++---
 drivers/staging/comedi/drivers/rtd520.c          | 6 +++---
 4 files changed, 13 insertions(+), 13 deletions(-)

Powered by blists - more mailing lists