linux-kernel - Re: [PATCH] xen: remove unnecessary condition check before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12d9b430-e08a-3e28-5289-028f6b395d11@suse.com>
Date:   Mon, 10 Sep 2018 11:52:16 +0200
From:   Juergen Gross <jgross@...e.com>
To:     zhong jiang <zhongjiang@...wei.com>, boris.ostrovsky@...cle.com
Cc:     xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xen: remove unnecessary condition check before kfree

On 08/09/18 16:18, zhong jiang wrote:
> kfree has taken null pointer into account. So just remove the
> condition check before kfree.
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/xen/xen-acpi-processor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c
> index fbb9137..7e1d49e 100644
> --- a/drivers/xen/xen-acpi-processor.c
> +++ b/drivers/xen/xen-acpi-processor.c
> @@ -268,7 +268,7 @@ static int push_pxx_to_hypervisor(struct acpi_processor *_pr)
>  		pr_warn("(_PXX): Hypervisor error (%d) for ACPI CPU%u\n",
>  			ret, _pr->acpi_id);
>  err_free:
> -	if (!IS_ERR_OR_NULL(dst_states))
> +	if (!IS_ERR(dst_states))

This is just a change of the condition, not a removal.

I don't think change is worth it.


Juergen