linux-kernel - Re: [Xen-devel] [PATCH V3 1/2] Drivers/PCI: Export pcie_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180910095231.GD18222@reaktio.net>
Date:   Mon, 10 Sep 2018 12:52:31 +0300
From:   Pasi Kärkkäinen <pasik@....fi>
To:     Sinan Kaya <okaya@...nel.org>
Cc:     Christoph Hellwig <hch@...radead.org>,
        Bjorn Helgaas <helgaas@...nel.org>, jgross@...e.com,
        Sinan Kaya <okaya@...eaurora.org>,
        Govinda Tatti <Govinda.Tatti@...cle.COM>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Satanand Burla <satananda.burla@...iumnetworks.com>,
        linux-pci@...r.kernel.org,
        Felix Manlunas <felix.manlunas@...iumnetworks.com>,
        linux-kernel@...r.kernel.org,
        Derek Chickles <derek.chickles@...iumnetworks.com>,
        Srikanth Jampala <Jampala.Srikanth@...ium.com>,
        JBeulich@...e.com, Russell Currey <ruscur@...sell.cc>,
        bhelgaas@...gle.com, xen-devel@...ts.xenproject.org,
        boris.ostrovsky@...cle.COM,
        Raghu Vatsavayi <raghu.vatsavayi@...iumnetworks.com>,
        roger.pau@...rix.com
Subject: Re: [Xen-devel] [PATCH V3 1/2] Drivers/PCI: Export pcie_has_flr()
 interface

Hi,

On Sun, Sep 09, 2018 at 10:33:02PM -0400, Sinan Kaya wrote:
> On 9/9/2018 2:59 PM, Pasi Kärkkäinen wrote:
> >I noticed pcie_has_flr() has been recently exported in upstream Linux:
> >https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2d2917f7747805a1f4188672f308d82a8ba01700
> >
> >Are there more changes / cleanups planned to these interfaces, as mentioned last year?
> >
> >(context: xen-pciback reset/do_flr features upstreaming, which kind of stalled last year when pcie_has_flr() wasn't exported at the time)
> 
> Exporting pcie_has_flr() is a very simple change which could have been done
> by the XEN porting effort.
> 
> Maybe, the right question is what is so special about XEN reset?
> 
> What feature PCI core is missing to support XEN FLR reset that caused
> the effort to stall?
>

Well one of the reasons probably was because Christoph was planning to deprecate the pcie_has_flr() functionality..

https://lists.xen.org/archives/html/xen-devel/2017-12/msg01057.html
https://lists.xen.org/archives/html/xen-devel/2017-12/msg01252.html

But now that pcie_has_flr() is exported and available I guess it's fine to continue using it also for xen-pciback :)


Thanks,

-- Pasi