linux-kernel - Re: [PATCH 11/11] dts: tc2: Update coresight bindings for hardware ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Sep 2018 18:15:27 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     Sudeep Holla <sudeep.holla@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        robh@...nel.org, frowand.list@...il.com,
        devicetree@...r.kernel.org, mathieu.poirier@...aro.org,
        arm@...nel.org, Liviu Dudau <liviu.dudau@....com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Subject: Re: [PATCH 11/11] dts: tc2: Update coresight bindings for hardware
 ports

On 09/11/2018 06:01 PM, Sudeep Holla wrote:
> On Tue, Sep 11, 2018 at 11:17:12AM +0100, Suzuki K Poulose wrote:
>> Switch to the new coresight bindings
>>
> 
> I still see the below warnings:
> 
> vexpress-v2p-ca15_a7.dtb: Warning (graph_child_address):
> 	/replicator/in-ports: graph node has single child node 'port@0',
> 	#address-cells/#size-cells are not necessary
> vexpress-v2p-ca15_a7.dtb: Warning (graph_child_address):
> 	/funnel@...40000/out-ports: graph node has single child node 'port@0',
> 	#address-cells/#size-cells are not necessary
> 
> I need the below patch to fix them, let me know if it looks OK, I can
> amend and apply.

Thanks for reporting. I purposefully added the "address-cells" and 
followed the format everywhere in the series thinking that, that is
indeed the formal way of doing it, rather than having implicit port
numbers. I can send an updated series fixing it everywhere.

Regards
Suzuki


> 
> Regards,
> Sudeep
> 
> -->8
> 
> diff --git a/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts b/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts
> index 3a5090616bc6..8b926c30ccd1 100644
> --- a/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts
> +++ b/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts
> @@ -443,11 +443,7 @@
>   		};
>   
>   		in-ports {
> -			#address-cells = <1>;
> -			#size-cells = <0>;
> -
> -			port@0 {
> -				reg = <0>;
> +			port {
>   				replicator_in_port0: endpoint {
>   					remote-endpoint = <&funnel_out_port0>;
>   				};
> @@ -462,11 +458,7 @@
>   		clocks = <&oscclk6a>;
>   		clock-names = "apb_pclk";
>   		out-ports {
> -			#address-cells = <1>;
> -			#size-cells = <0>;
> -
> -			port@0 {
> -				reg = <0>;
> +			port {
>   				funnel_out_port0: endpoint {
>   					remote-endpoint =
>   						<&replicator_in_port0>;
>