lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 11 Sep 2018 04:06:46 +0100
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Compiler flags for libapi and libtraceevent

I noticed that tools/lib/api/Makefile has these conditional
assignments, similar to tools/perf/Makefile.config:

ifeq ($(DEBUG),0)
ifeq ($(CC_NO_CLANG), 0)
  CFLAGS += -O3
else
  CFLAGS += -O6
endif
endif

ifeq ($(DEBUG),0)
  CFLAGS += -D_FORTIFY_SOURCE
endif

But it doesn't set DEBUG to 0 by default, and nothing under tools/perf
exports its value of CFLAGS or DEBUG.

tools/lib/traceevent/Makefile doesn't seem to have any logic to enable
optimisation or Fortify.

Shouldn't these libraries both have optimisations and Fortify turned on
by default, like perf itself?

Ben.

-- 
Ben Hutchings
Computers are not intelligent.	They only think they are.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ