linux-kernel - Re: Compiler flags for libapi and libtraceevent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180913080439.GA24224@krava>
Date:   Thu, 13 Sep 2018 10:04:39 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Ben Hutchings <ben@...adent.org.uk>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: Compiler flags for libapi and libtraceevent

On Tue, Sep 11, 2018 at 04:06:46AM +0100, Ben Hutchings wrote:
> I noticed that tools/lib/api/Makefile has these conditional
> assignments, similar to tools/perf/Makefile.config:
> 
> ifeq ($(DEBUG),0)
> ifeq ($(CC_NO_CLANG), 0)
>   CFLAGS += -O3
> else
>   CFLAGS += -O6
> endif
> endif
> 
> ifeq ($(DEBUG),0)
>   CFLAGS += -D_FORTIFY_SOURCE
> endif
> 
> But it doesn't set DEBUG to 0 by default, and nothing under tools/perf
> exports its value of CFLAGS or DEBUG.

hum, AFAICS tools/perf/Makefile.perf exports CFLAGS:

export srctree OUTPUT RM CC CXX LD AR CFLAGS CXXFLAGS V BISON FLEX AWK

jirka

> 
> tools/lib/traceevent/Makefile doesn't seem to have any logic to enable
> optimisation or Fortify.
> 
> Shouldn't these libraries both have optimisations and Fortify turned on
> by default, like perf itself?
> 
> Ben.
> 
> -- 
> Ben Hutchings
> Computers are not intelligent.	They only think they are.
>