linux-kernel - Re: [PATCH v2 5/6] drivers: qcom: rpmh-rsc: write PDC data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180912223756.GL22824@google.com>
Date:   Wed, 12 Sep 2018 15:37:56 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Lina Iyer <ilina@...eaurora.org>
Cc:     Raju P L S S S N <rplsssn@...eaurora.org>, andy.gross@...aro.org,
        david.brown@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org, rnayak@...eaurora.org,
        bjorn.andersson@...aro.org, linux-kernel@...r.kernel.org,
        sboyd@...nel.org, evgreen@...omium.org, dianders@...omium.org
Subject: Re: [PATCH v2 5/6] drivers: qcom: rpmh-rsc: write PDC data

On Wed, Sep 12, 2018 at 04:33:56PM -0600, Lina Iyer wrote:
> On Wed, Sep 12 2018 at 16:28 -0600, Matthias Kaehlcke wrote:
> > On Fri, Jul 27, 2018 at 03:34:48PM +0530, Raju P L S S S N wrote:
> > > From: Lina Iyer <ilina@...eaurora.org>
> > > 
> > > The Power Domain Controller can be programmed to wakeup the RSC and
> > > setup the resources back in the active state, before the processor is
> > > woken up by a timer interrupt. The wakeup value from the timer hardware
> > > can be copied to the PDC which has its own timer and is in an always-on
> > > power domain. Programming the wakeup value is done through a separate
> > > register on the RSC.
> > > 
> > > Signed-off-by: Lina Iyer <ilina@...eaurora.org>
> > > Signed-off-by: Raju P.L.S.S.S.N <rplsssn@...eaurora.org>
> > > ---
> > > Changes in v2:
> > >    - Remove unnecessary EXPORT_SYMBOL
> > > ---
> > 
> > > +int rpmh_rsc_write_pdc_data(struct rsc_drv *drv, const struct tcs_request *msg)
> > > +{
> > > +	int i;
> > > +	void __iomem *addr = drv->base + RSC_PDC_DRV_DATA;
> > > +
> > > +	if (!msg || !msg->cmds || msg->num_cmds != RSC_PDC_DATA_SIZE)
> > > +		return -EINVAL;
> > 
> > Is it really always exactly 2 (RSC_PDC_DATA_SIZE) commands?
> > 
> Yes, always.

Thanks for the confirmation!

Reviewed-by: Matthias Kaehlcke <mka@...omium.org>