linux-kernel - Re: [RFC 0/4] perf: Per PMU access controls (paranoid setting)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3361d8e1-50a0-2404-78cb-b83ca345b565@ursulin.net>
Date:   Wed, 12 Sep 2018 09:41:40 +0100
From:   Tvrtko Ursulin <tursulin@...ulin.net>
To:     Alexey Budankov <alexey.budankov@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Cc:     Tvrtko Ursulin <tvrtko.ursulin@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>,
        Andi Kleen <ak@...ux.intel.com>, x86@...nel.org
Subject: Re: [RFC 0/4] perf: Per PMU access controls (paranoid setting)


On 12/09/18 07:52, Alexey Budankov wrote:
> 
> Hi,
> 
> Is there any plans or may be even progress on that so far?

It's hanging in the back of my mind. AFAIR after last round there was a 
build failure or two to fix on more exotic (to me) hardware, and Jiri 
Olsa provided a tools/perf snippet supporting the feature.

But essentially I haven't done any work on it since due not seeing the 
route to upstream. :( In other words, will someone review it and will 
that r-b make it have a chance of getting into some tree. If I had a 
clear statement from someone with authority in these aspects I would 
progress it, but otherwise it felt like it's not going anywhere.

Regards,

Tvrtko


> Thanks,
> Alexey
> 
> On 26.06.2018 18:36, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@...el.com>
>>
>> For situations where sysadmins might want to allow different level of
>> access control for different PMUs, we start creating per-PMU
>> perf_event_paranoid controls in sysfs.
>>
>> These work in equivalent fashion as the existing perf_event_paranoid
>> sysctl, which now becomes the parent control for each PMU.
>>
>> On PMU registration the global/parent value will be inherited by each PMU,
>> as it will be propagated to all registered PMUs when the sysctl is
>> updated.
>>
>> At any later point individual PMU access controls, located in
>> <sysfs>/device/<pmu-name>/perf_event_paranoid, can be adjusted to achieve
>> fine grained access control.
>>
>> Discussion from previous posting:
>> https://lkml.org/lkml/2018/5/21/156
>>
>> Cc: Thomas Gleixner <tglx@...utronix.de>
>> Cc: Peter Zijlstra <peterz@...radead.org>
>> Cc: Ingo Molnar <mingo@...hat.com>
>> Cc: "H. Peter Anvin" <hpa@...or.com>
>> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
>> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
>> Cc: Jiri Olsa <jolsa@...hat.com>
>> Cc: Namhyung Kim <namhyung@...nel.org>
>> Cc: Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>
>> Cc: Andi Kleen <ak@...ux.intel.com>
>> Cc: Alexey Budankov <alexey.budankov@...ux.intel.com>
>> Cc: linux-kernel@...r.kernel.org
>> Cc: x86@...nel.org
>>
>> Tvrtko Ursulin (4):
>>    perf: Move some access checks later in perf_event_open
>>    perf: Pass pmu pointer to perf_paranoid_* helpers
>>    perf: Allow per PMU access control
>>    perf Documentation: Document the per PMU perf_event_paranoid interface
>>
>>   .../sysfs-bus-event_source-devices-events     |  14 +++
>>   arch/powerpc/perf/core-book3s.c               |   2 +-
>>   arch/x86/events/intel/bts.c                   |   2 +-
>>   arch/x86/events/intel/core.c                  |   2 +-
>>   arch/x86/events/intel/p4.c                    |   2 +-
>>   include/linux/perf_event.h                    |  18 ++-
>>   kernel/events/core.c                          | 104 +++++++++++++++---
>>   kernel/sysctl.c                               |   4 +-
>>   kernel/trace/trace_event_perf.c               |   6 +-
>>   9 files changed, 123 insertions(+), 31 deletions(-)
>>
>