linux-kernel - Re: [PATCH V6 2/2] x86/efi: Add efi page fault handler to recover from page faults caused by the firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu9yDEfUFkTK0orYLjRfs+=WXwPvr44a2q0ALiWMNEpmDg@mail.gmail.com>
Date:   Wed, 12 Sep 2018 20:58:36 +0200
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Sai Praneeth Prakhya <sai.praneeth.prakhya@...el.com>,
        linux-efi <linux-efi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Al Stone <astone@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Ingo Molnar <mingo@...nel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Bhupesh Sharma <bhsharma@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH V6 2/2] x86/efi: Add efi page fault handler to recover
 from page faults caused by the firmware

On 12 September 2018 at 20:56, Thomas Gleixner <tglx@...utronix.de> wrote:
> On Tue, 11 Sep 2018, Sai Praneeth Prakhya wrote:
>> diff --git a/drivers/firmware/efi/runtime-wrappers.c b/drivers/firmware/efi/runtime-wrappers.c
>> index b18b2d864c2c..7455277a3b65 100644
>> --- a/drivers/firmware/efi/runtime-wrappers.c
>> +++ b/drivers/firmware/efi/runtime-wrappers.c
>> @@ -61,6 +61,11 @@ struct efi_runtime_work efi_rts_work;
>>  ({                                                                   \
>>       efi_rts_work.status = EFI_ABORTED;                              \
>>                                                                       \
>> +     if (!efi_enabled(EFI_RUNTIME_SERVICES)) {                       \
>> +             pr_info("Aborting! EFI Runtime Services disabled\n");   \
>
> This probaby wants to be pr_info_ince().
>

I can fix that up when applying.

> Other than that:
>
>       Reviewed-by: Thomas Gleixner <tglx@...utronix.de>

Thanks! I will queue this up in efi/next