linux-kernel - Re: [PATCH] sched/core: Fix compiling warring in smp=n case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2278505d-94ce-ab68-dbe3-5e4e1c9094ef@163.com>
Date:   Thu, 13 Sep 2018 17:55:25 +0800
From:   Dou Liyang <dou_liyang@....com>
To:     linux-kernel@...r.kernel.org, x86@...nel.org
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        peterz@...radead.org, vincent.guittot@...aro.org,
        Dou Liyang <douly.fnst@...fujitsu.com>
Subject: Re: [PATCH] sched/core: Fix compiling warring in smp=n case



At 08/10/2018 10:35 AM, Dou Liyang wrote:
> When compiling kernel with SMP disabled, the build warns with:
> 
> kernel/sched/core.c: In function ‘update_rq_clock_task’:
> kernel/sched/core.c:139:17: warning: unused variable ‘irq_delta’ [-Wunused-variable]
>    s64 steal = 0, irq_delta = 0;
> 
> Fix this by revert the HAVE_SCHED_AVG_IRQ to
> 
>    defined(CONFIG_IRQ_TIME_ACCOUNTING) || defined(CONFIG_PARAVIRT_TIME_ACCOUNTING)
> 
> Fixes: 2e62c4743adc ("sched/fair: Remove #ifdefs from scale_rt_capacity()")

Hi,

  Miguel also found this warning. Can we pick it up now? ;-)

Thanks,
	dou