linux-kernel - Re: [PATCH] sched/core: Fix compiling warring in smp=n case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 14 Sep 2018 18:48:57 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Dou Liyang <dou_liyang@....com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dou Liyang <douly.fnst@...fujitsu.com>
Subject: Re: [PATCH] sched/core: Fix compiling warring in smp=n case

Hi,

On Thu, Sep 13, 2018 at 11:55 AM, Dou Liyang <dou_liyang@....com> wrote:
>
>
> At 08/10/2018 10:35 AM, Dou Liyang wrote:
>>
>> When compiling kernel with SMP disabled, the build warns with:
>>
>> kernel/sched/core.c: In function ‘update_rq_clock_task’:
>> kernel/sched/core.c:139:17: warning: unused variable ‘irq_delta’
>> [-Wunused-variable]
>>    s64 steal = 0, irq_delta = 0;
>>
>> Fix this by revert the HAVE_SCHED_AVG_IRQ to
>>
>>    defined(CONFIG_IRQ_TIME_ACCOUNTING) ||
>> defined(CONFIG_PARAVIRT_TIME_ACCOUNTING)
>>
>> Fixes: 2e62c4743adc ("sched/fair: Remove #ifdefs from
>> scale_rt_capacity()")
>
>
> Hi,
>
>  Miguel also found this warning. Can we pick it up now? ;-)

Also Zhong has just sent another patch for this.

Whenever this is picked up, feel free to add:

  Acked-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>

Cheers,
Miguel