linux-kernel - mutex and rcu list traversal idiosyncrasy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <E4626316-0683-45DF-9F09-D602FC982E21@oracle.com>
Date:   Thu, 13 Sep 2018 13:55:44 +0200
From:   Håkon Bugge <haakon.bugge@...cle.com>
To:     faisal.latif@...el.com, shiraz.saleem@...el.com
Cc:     OFED mailing list <linux-rdma@...r.kernel.org>,
        linux-kernel@...r.kernel.org, Doug Ledford <dledford@...hat.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        anjali.singhai@...el.com,
        Shannon Nelson <shannon.nelson@...cle.com>
Subject: mutex and rcu list traversal idiosyncrasy

Hi Faisal,


In commit f27b4746f378 ("i40iw: add connection management code") you have in i40iw_add_mqh_6():

rtnl_lock();
for_each_netdev_rcu(...) {
	[]
}
rtnl_unlock();

Shouldn't this read:

rtnl_lock();
for_each_netdev(...) {
	[]
}
rtnl_unlock();

or

rcu_read_lock();
for_each_netdev_rcu(...) {
	[]
}
rcu_read_unlock();


?



Thx, Håkon