linux-kernel - Re: mutex and rcu list traversal idiosyncrasy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180914234631.GA20084@ssaleem-MOBL4.amr.corp.intel.com>
Date:   Fri, 14 Sep 2018 18:46:31 -0500
From:   Shiraz Saleem <shiraz.saleem@...el.com>
To:     Håkon Bugge <haakon.bugge@...cle.com>
Cc:     "Latif, Faisal" <faisal.latif@...el.com>,
        OFED mailing list <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Doug Ledford <dledford@...hat.com>,
        "Hefty, Sean" <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        "Singhai, Anjali" <anjali.singhai@...el.com>,
        Shannon Nelson <shannon.nelson@...cle.com>
Subject: Re: mutex and rcu list traversal idiosyncrasy

On Thu, Sep 13, 2018 at 05:55:44AM -0600, Håkon Bugge wrote:
> Hi Faisal,
> 
> 
> In commit f27b4746f378 ("i40iw: add connection management code") you have in i40iw_add_mqh_6():
> 
> rtnl_lock();
> for_each_netdev_rcu(...) {
> 	[]
> }
> rtnl_unlock();
> 
> Shouldn't this read:
> rtnl_lock();
> for_each_netdev(...) {
> 	[]
> }
> rtnl_unlock();
>

Yes.