linux-kernel - Re: [PATCH] power_supply: sysfs: ratelimit property read error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa60b825-cd9e-91d7-c422-ee3b147d68c1@lechnology.com>
Date:   Wed, 12 Sep 2018 19:51:03 -0500
From:   David Lechner <david@...hnology.com>
To:     Sebastian Reichel <sre@...nel.org>, linux-pm@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power_supply: sysfs: ratelimit property read error
 message

On 09/12/2018 07:48 PM, David Lechner wrote:
> This adds ratelimiting to the message that is printed when reading a
> power supply property via sysfs returns an error. This will prevent
> userspace applications from unintentionally dDOSing the system by
> continuosuly reading a property that returns an error.

s/continuosuly/continuously/

> 
> Signed-off-by: David Lechner <david@...hnology.com>
> ---
>   drivers/power/supply/power_supply_sysfs.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> index 6170ed8b6854..dce24f596160 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -131,7 +131,8 @@ static ssize_t power_supply_show_property(struct device *dev,
>   				dev_dbg(dev, "driver has no data for `%s' property\n",
>   					attr->attr.name);
>   			else if (ret != -ENODEV && ret != -EAGAIN)
> -				dev_err(dev, "driver failed to report `%s' property: %zd\n",
> +				dev_err_ratelimited(dev,
> +					"driver failed to report `%s' property: %zd\n",
>   					attr->attr.name, ret);
>   			return ret;
>   		}
>