linux-kernel - Re: [PATCH] staging: rtl8188eu: remove code that is valid only for 5 GHz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180914155905.4891-1-r.weclawski@gmail.com>
Date:   Fri, 14 Sep 2018 17:58:58 +0200
From:   Robert Węcławski <r.weclawski@...il.com>
To:     dan.carpenter@...cle.com
Cc:     Robert Węcławski <r.weclawski@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Straube <straube.linux@...il.com>,
        Bhaskar Singh <bhaskar.kernel@...il.com>,
        Kacper Kołodziej <kacper@...odziej.it>,
        Janani Sankara Babu <jananis37@...il.com>,
        Santha Meena Ramamoorthy <santhameena13@...il.com>,
        Kees Cook <keescook@...omium.org>,
        Manish Shrestha <manishshrestha2006@...il.com>,
        Valentine Sinitsyn <valentine.sinitsyn@...il.com>,
        Aishwarya Pant <aishpant@...il.com>,
        Colin Ian King <colin.king@...onical.com>,
        Jia-Ju Bai <baijiaju1990@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: remove code that is valid only for 5 GHz

> On Thu, Sep 13, 2018 at 10:32:39PM +0200, Robert Węcławski wrote:
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> > index eca06f05c0c4..b610443f2ac6 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> > +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> > @@ -1819,16 +1819,6 @@ void rtw_update_registrypriv_dev_network(struct adapter *adapter)
> >  	case WIRELESS_11BG_24N:
> >  		pdev_network->NetworkTypeInUse = Ndis802_11OFDM24;
> >  		break;
> > -	case WIRELESS_11A:
> > -	case WIRELESS_11A_5N:
> > -		pdev_network->NetworkTypeInUse = Ndis802_11OFDM5;
> > -		break;
> > -	case WIRELESS_11ABGN:
> > -		if (pregistrypriv->channel > 14)
> > -			pdev_network->NetworkTypeInUse = Ndis802_11OFDM5;
> > -		else
> > -			pdev_network->NetworkTypeInUse = Ndis802_11OFDM24;
> > -		break;
> >  	default:
> > 		/*  TODO */
> > 		break;
>
> Are you sure about this chunk?  I would have thought that <= 14 was not
> 5G.  (I try to avoid rhetorical questions and I don't know the answer
> here).
> 
> regards,
> dan carpenter

I'm 99% sure this part is not needed because this chipset only supports B, G and N WiFi networks.

I think we should add pdev_network->NetworkTypeInUse = Ndis802_110FDM5 to default case to be 100% sure it won't break anything.
If we do this we can be sure pdev_network->NetworkTypeInUse will be set.
Should I make a new version of this patch?