linux-kernel - Re: [PATCH] staging: rtl8188eu: remove code that is valid only for 5 GHz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180914061232.323jxklcp75ugtvr@mwanda>
Date:   Fri, 14 Sep 2018 09:12:32 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Robert Węcławski <r.weclawski@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        Kees Cook <keescook@...omium.org>,
        Kacper Kołodziej <kacper@...odziej.it>,
        Mihaela Muraru <mihaela.muraru21@...il.com>,
        Valentine Sinitsyn <valentine.sinitsyn@...il.com>,
        linux-kernel@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
        Janani Sankara Babu <jananis37@...il.com>,
        Colin Ian King <colin.king@...onical.com>,
        Santha Meena Ramamoorthy <santhameena13@...il.com>
Subject: Re: [PATCH] staging: rtl8188eu: remove code that is valid only for 5
 GHz

On Thu, Sep 13, 2018 at 10:32:39PM +0200, Robert Węcławski wrote:
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> index eca06f05c0c4..b610443f2ac6 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> @@ -1819,16 +1819,6 @@ void rtw_update_registrypriv_dev_network(struct adapter *adapter)
>  	case WIRELESS_11BG_24N:
>  		pdev_network->NetworkTypeInUse = Ndis802_11OFDM24;
>  		break;
> -	case WIRELESS_11A:
> -	case WIRELESS_11A_5N:
> -		pdev_network->NetworkTypeInUse = Ndis802_11OFDM5;
> -		break;
> -	case WIRELESS_11ABGN:
> -		if (pregistrypriv->channel > 14)
> -			pdev_network->NetworkTypeInUse = Ndis802_11OFDM5;
> -		else
> -			pdev_network->NetworkTypeInUse = Ndis802_11OFDM24;
> -		break;
>  	default:
>  		/*  TODO */
>  		break;

Are you sure about this chunk?  I would have thought that <= 14 was not
5G.  (I try to avoid rhetorical questions and I don't know the answer
here).

regards,
dan carpenter