linux-kernel - Re: [PATCH v2] mips: switch to NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180914195300.7wnmsph2qhpixm7s@pburton-laptop>
Date:   Fri, 14 Sep 2018 12:53:00 -0700
From:   Paul Burton <paul.burton@...s.com>
To:     Mike Rapoport <rppt@...ux.vnet.ibm.com>
Cc:     Serge Semin <fancer.lancer@...il.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>,
        Huacai Chen <chenhc@...ote.com>,
        Michal Hocko <mhocko@...nel.org>, linux-mips@...ux-mips.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mips: switch to NO_BOOTMEM

Hi Mike,

On Mon, Sep 10, 2018 at 12:23:18PM +0300, Mike Rapoport wrote:
> MIPS already has memblock support and all the memory is already registered
> with it.
> 
> This patch replaces bootmem memory reservations with memblock ones and
> removes the bootmem initialization.
> 
> Since memblock allocates memory in top-down mode, we ensure that memblock
> limit is max_low_pfn to prevent allocations from the high memory.
> 
> To have the exceptions base in the lower 512M of the physical memory, its
> allocation in arch/mips/kernel/traps.c::traps_init() is using bottom-up
> mode.
> 
> Signed-off-by: Mike Rapoport <rppt@...ux.vnet.ibm.com>
> ---
> v2:
> * set memblock limit to max_low_pfn to avoid allocation attempts from high
> memory
> * use boottom-up mode for allocation of the exceptions base
> 
> Build tested with *_defconfig.
> Boot tested with qemu-system-mips64el for 32r6el, 64r6el and fuloong2e
> defconfigs.
> Boot tested with qemu-system-mipsel for malta defconfig.
> 
>  arch/mips/Kconfig                      |  1 +
>  arch/mips/kernel/setup.c               | 99 ++++++++--------------------------
>  arch/mips/kernel/traps.c               |  3 ++
>  arch/mips/loongson64/loongson-3/numa.c | 34 ++++++------
>  arch/mips/sgi-ip27/ip27-memory.c       | 11 ++--
>  5 files changed, 46 insertions(+), 102 deletions(-)

Thanks - applied to mips-next for 4.20.

Apologies for the delay, my son decided to be born a few weeks early &
scupper my plans :)

Paul