linux-kernel - Re: [PATCH] hwmon: Use PTR_ERR_OR_ZERO instead of reimplementing its function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180916004318.GA30797@roeck-us.net>
Date:   Sat, 15 Sep 2018 17:43:18 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     kronos.it@...il.com, jdelvare@...e.com,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: Use PTR_ERR_OR_ZERO instead of reimplementing its
 function

On Tue, Sep 11, 2018 at 08:03:37PM +0800, zhong jiang wrote:
> PTR_ERR_OR_ZERO has implemented the same function. We prefer to use
> inlined function rather than code-opened implementation.
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>

Applied to hwmon-next. For future patches, please also refer to the
affected driver in the Subject line, unless the change is in the
subsystem core code.

Thanks,
Guenter

> ---
>  drivers/hwmon/asus_atk0110.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c
> index a6636fe..a7cf008 100644
> --- a/drivers/hwmon/asus_atk0110.c
> +++ b/drivers/hwmon/asus_atk0110.c
> @@ -1210,10 +1210,8 @@ static int atk_register_hwmon(struct atk_data *data)
>  	data->hwmon_dev = hwmon_device_register_with_groups(dev, "atk0110",
>  							    data,
>  							    data->attr_groups);
> -	if (IS_ERR(data->hwmon_dev))
> -		return PTR_ERR(data->hwmon_dev);
>  
> -	return 0;
> +	return PTR_ERR_OR_ZERO(data->hwmon_dev);
>  }
>  
>  static int atk_probe_if(struct atk_data *data)
> -- 
> 1.7.12.4
>