linux-kernel - Re: [PATCH V3 5/6] x86/intel_rdt: Use perf infrastructure for measurements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <daeb5e60-de3e-4f08-0e06-25ab83bbe2fe@intel.com>
Date:   Mon, 17 Sep 2018 09:54:14 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     tglx@...utronix.de, fenghua.yu@...el.com, tony.luck@...el.com,
        mingo@...hat.com, acme@...nel.org, gavin.hindman@...el.com,
        jithu.joseph@...el.com, dave.hansen@...el.com, hpa@...or.com,
        x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 5/6] x86/intel_rdt: Use perf infrastructure for
 measurements

Hi Peter,

On 9/17/2018 1:58 AM, Peter Zijlstra wrote:
> On Tue, Sep 11, 2018 at 10:14:36AM -0700, Reinette Chatre wrote:
>> +static int measure_l2_residency(void *_plr)
>> +{
> 
>> +	measure_residency_fn(&perf_miss_attr, &perf_hit_attr, plr, &counts);
> 
>> +}
>> +
>> +static int measure_l3_residency(void *_plr)
>> +{
> 
>> +	measure_residency_fn(&perf_miss_attr, &perf_hit_attr, plr, &counts);
> 
> Not sure it's important, but both sites loose the error return.
> 

measure_l2_residency() as well as measure_l3_residency() are thread
functions so this error does not propagate directly to the caller.

Even so, by not exiting the thread here if measure_residency_fn() fails
the tracepoints will be written with zeroes. If we exited here the
tracepoints will not be written and the trace buffer will be empty when
the user searches for the measurement data. Do you perhaps have an
inclination to which a user would prefer?

Reinette