linux-kernel - Re: [PATCH V3 2/6] perf/core: Add helper to obtain performance counter index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Sep 2018 01:07:58 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Reinette Chatre <reinette.chatre@...el.com>
Cc:     tglx@...utronix.de, fenghua.yu@...el.com, tony.luck@...el.com,
        mingo@...hat.com, acme@...nel.org, gavin.hindman@...el.com,
        jithu.joseph@...el.com, dave.hansen@...el.com, hpa@...or.com,
        x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 2/6] perf/core: Add helper to obtain performance
 counter index

On Mon, Sep 17, 2018 at 09:37:14AM -0700, Reinette Chatre wrote:
> On 9/17/2018 1:23 AM, Peter Zijlstra wrote:

> > I said arch/x86/include/asm/perf_events.h and call it:
> > x86_perf_rdpmc_index().
> > 
> > This function is very much x86 specific.

> Moving it to arch/x86/include/asm/perf_event.h is not trivial since this
> file is not familiar with struct perf_event.

Urgh, right you are. Does it work if you make it a regular function
instead of an inline? Put the thing in arch/x86/events/core.c or so and
only an extern decl in asm/perf_event.h.