[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180917203438.maary2eo64dbuhw2@sghpc.golosunov.pp.ru>
Date: Tue, 18 Sep 2018 00:34:39 +0400
From: Stepan Golosunov <stepan@...osunov.pp.ru>
To: Deepa Dinamani <deepa.kernel@...il.com>
Cc: viro@...iv.linux.org.uk, tglx@...utronix.de,
linux-kernel@...r.kernel.org, arnd@...db.de,
y2038@...ts.linaro.org, linux-fsdevel@...r.kernel.org,
linux-api@...r.kernel.org, linux-aio@...ck.org
Subject: Re: [PATCH v3 4/5] pselect6: use __kernel_timespec
On Sun, Sep 16, 2018 at 06:04:57PM -0700, Deepa Dinamani wrote:
> static long do_compat_pselect(int n, compat_ulong_t __user *inp,
> compat_ulong_t __user *outp, compat_ulong_t __user *exp,
> - struct old_timespec32 __user *tsp, compat_sigset_t __user *sigmask,
> - compat_size_t sigsetsize)
> + void __user *tsp, compat_sigset_t __user *sigmask,
> + compat_size_t sigsetsize, enum poll_time_type type)
> {
> sigset_t ksigmask, sigsaved;
> struct timespec64 ts, end_time, *to = NULL;
> int ret;
>
> if (tsp) {
> - if (get_old_timespec32(&ts, tsp))
> - return -EFAULT;
> + switch (type) {
> + case PT_OLD_TIMESPEC:
> + if (get_old_timespec32(&ts, tsp))
> + return -EFAULT;
> + break;
> + case PT_TIMESPEC:
> + if (get_old_timespec32(&ts, tsp))
> + return -EFAULT;
> + break;
> + default:
> + BUG();
> + }
One of the two get_old_timespec32 calls here should be
get_timespec64.
Powered by blists - more mailing lists