linux-kernel - Re: [PATCH v3 4/5] pselect6: use __kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Sep 2018 14:16:09 -0700
From:   Deepa Dinamani <deepa.kernel@...il.com>
To:     stepan@...osunov.pp.ru
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        Linux API <linux-api@...r.kernel.org>,
        linux-aio <linux-aio@...ck.org>
Subject: Re: [PATCH v3 4/5] pselect6: use __kernel_timespec

On Mon, Sep 17, 2018 at 1:34 PM Stepan Golosunov <stepan@...osunov.pp.ru> wrote:
>
> On Sun, Sep 16, 2018 at 06:04:57PM -0700, Deepa Dinamani wrote:
> >  static long do_compat_pselect(int n, compat_ulong_t __user *inp,
> >       compat_ulong_t __user *outp, compat_ulong_t __user *exp,
> > -     struct old_timespec32 __user *tsp, compat_sigset_t __user *sigmask,
> > -     compat_size_t sigsetsize)
> > +     void __user *tsp, compat_sigset_t __user *sigmask,
> > +     compat_size_t sigsetsize, enum poll_time_type type)
> >  {
> >       sigset_t ksigmask, sigsaved;
> >       struct timespec64 ts, end_time, *to = NULL;
> >       int ret;
> >
> >       if (tsp) {
> > -             if (get_old_timespec32(&ts, tsp))
> > -                     return -EFAULT;
> > +             switch (type) {
> > +             case PT_OLD_TIMESPEC:
> > +                     if (get_old_timespec32(&ts, tsp))
> > +                             return -EFAULT;
> > +                     break;
> > +             case PT_TIMESPEC:
> > +                     if (get_old_timespec32(&ts, tsp))
> > +                             return -EFAULT;
> > +                     break;
> > +             default:
> > +                     BUG();
> > +             }
>
> One of the two get_old_timespec32 calls here should be
> get_timespec64.

Right. It is a copy paste bug.

Thanks,
Deepa