linux-kernel - Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown operation was requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Sep 2018 16:28:28 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     KY Srinivasan <kys@...rosoft.com>
Cc:     "olaf@...fle.de" <olaf@...fle.de>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Michael Kelley (EOSG)" <Michael.H.Kelley@...rosoft.com>,
        "apw@...onical.com" <apw@...onical.com>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        vkuznets <vkuznets@...hat.com>
Subject: Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown
 operation was requested

On Mon, Sep 17, 2018 at 02:16:48PM +0000, KY Srinivasan wrote:
> 
> 
> > -----Original Message-----
> > From: Greg KH <gregkh@...uxfoundation.org>
> > Sent: Sunday, September 16, 2018 9:56 PM
> > To: KY Srinivasan <kys@...rosoft.com>
> > Cc: linux-kernel@...r.kernel.org; devel@...uxdriverproject.org;
> > olaf@...fle.de; apw@...onical.com; jasowang@...hat.com; Stephen
> > Hemminger <sthemmin@...rosoft.com>; Michael Kelley (EOSG)
> > <Michael.H.Kelley@...rosoft.com>; vkuznets <vkuznets@...hat.com>
> > Subject: Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown
> > operation was requested
> > 
> > On Mon, Sep 17, 2018 at 04:14:55AM +0000, kys@...uxonhyperv.com wrote:
> > > From: Vitaly Kuznetsov <vkuznets@...hat.com>
> > >
> > > 'error' variable is left uninitialized in case we see an unknown operation.
> > > As we don't immediately return and proceed to pwrite() we need to set it
> > > to something, HV_E_FAIL sounds good enough.
> > >
> > > Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> > > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> > > ---
> > >  tools/hv/hv_fcopy_daemon.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > No need to backport for stable?
> Thanks for pointing this out. Should I resubmit with the stable tag?

I can do it... :)