linux-kernel - RE: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB1038A85DC36665244DF2104A991D0@VI1PR04MB1038.eurprd04.prod.outlook.com>
Date:   Tue, 18 Sep 2018 08:28:23 +0000
From:   Yogesh Narayan Gaur <yogeshnarayan.gaur@....com>
To:     Frieder Schrempf <frieder.schrempf@...eet.de>,
        Boris Brezillon <boris.brezillon@...tlin.com>
CC:     "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "marek.vasut@...il.com" <marek.vasut@...il.com>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "robh@...nel.org" <robh@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "computersforpeace@...il.com" <computersforpeace@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI
 controller

Hi Frieder,

> -----Original Message-----
> From: Frieder Schrempf [mailto:frieder.schrempf@...eet.de]
> Sent: Tuesday, September 18, 2018 1:52 PM
> To: Boris Brezillon <boris.brezillon@...tlin.com>; Yogesh Narayan Gaur
> <yogeshnarayan.gaur@....com>
> Cc: linux-mtd@...ts.infradead.org; marek.vasut@...il.com; linux-
> spi@...r.kernel.org; devicetree@...r.kernel.org; robh@...nel.org;
> mark.rutland@....com; shawnguo@...nel.org; linux-arm-
> kernel@...ts.infradead.org; computersforpeace@...il.com; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH v2 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller
> 
> Hi Boris, Yogesh,
> 
> On 17.09.2018 13:37, Boris Brezillon wrote:
> > Hi Yogesh,
> >
> > On Mon, 17 Sep 2018 15:18:26 +0530
> > Yogesh Gaur <yogeshnarayan.gaur@....com> wrote:
> >
> >> +
> >> +	/*
> >> +	 * R/W functions for big- or little-endian registers:
> >> +	 * The FSPI controller's endianness is independent of
> >> +	 * the CPU core's endianness. So far, although the CPU
> >> +	 * core is little-endian the FSPI controller can use
> >> +	 * big-endian or little-endian.
> >> +	 */
> >> +	if (of_property_read_bool(np, "big-endian")) {
> >> +		f->write = fspi_writel_be;
> >> +		f->read = fspi_readl_be;
> >> +	} else {
> >> +		f->write = fspi_writel;
> >> +		f->read = fspi_readl;
> >> +	}
> >
> > Hm, isn't it something you can extract from the compatible string? I'd
> > rather not allow users to set that in their DT if it's not something
> > you can change.
> 
> This was copied from the QSPI driver, but I think Boris is right. This seems to be a
> fixed SOC-specific setting and we shouldn't set it in the DT. This applies to QSPI
> and FSPI alike.
> 

Yes, it can be modified. Instead of reading endianness property from device tree can be moved to the platform structure nxp_fspi_devtype_data which is linked with the compatible string
{ .compatible = "nxp,lx2160a-fspi", .data = (void *)&lx2160a_data, }

Thanks.

Would send the changes in next version.

--
Regards,
Yogesh Gaur.

> Regards,
> Frieder
> 
> >
> > Regards,
> >
> > Boris
> >