linux-kernel - Re: [PATCHv3 1/2] scsi: ibmvscsis: Fix a stringop-overflow warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B86907DE-444B-498D-A402-78190A5A402B@catalogicsoftware.com>
Date:   Tue, 18 Sep 2018 00:37:11 +0000
From:   "Ly, Bryant" <bly@...alogicsoftware.com>
To:     Laura Abbott <labbott@...hat.com>
CC:     "Bryant G. Ly" <bryantly@...ux.vnet.ibm.com>,
        Michael Cyr <mikecyr@...ux.vnet.ibm.com>,
        Kees Cook <keescook@...omium.org>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv3 1/2] scsi: ibmvscsis: Fix a stringop-overflow warning



> On Sep 11, 2018, at 2:22 PM, Laura Abbott <labbott@...hat.com> wrote:
> 
> There's currently a warning about string overflow with strncat:
> 
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe':
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3479:2: error: 'strncat' specified
> bound 64 equals destination size [-Werror=stringop-overflow=]
>  strncat(vscsi->eye, vdev->name, MAX_EYE);
>  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Switch to a single snprintf instead of a strcpy + strcat to handle this
> cleanly.
> 
> Signed-off-by: Laura Abbott <labbott@...hat.com>
> ---
> v3: Make sure there is an extra space in the partition name
> ---
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 

Reviewed-by: Bryant G. Ly bly@...alogicsoftware.com

I sent a PR to update my email from bryantly@...ux.vnet.ibm.com a week ago.

-Bryant