linux-kernel - Re: [PATCHv2 2/2] scsi: ibmvscsis: Ensure partition name is properly NUL terminated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Sep 2018 19:38:17 -0500
From:   Bryant Ly <bryant.ly@...com>
To:     Laura Abbott <labbott@...hat.com>
Cc:     "Bryant G. Ly" <bryantly@...ux.vnet.ibm.com>,
        Michael Cyr <mikecyr@...ux.vnet.ibm.com>,
        Kees Cook <keescook@...omium.org>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 2/2] scsi: ibmvscsis: Ensure partition name is properly
 NUL terminated



> On Sep 11, 2018, at 2:22 PM, Laura Abbott <labbott@...hat.com> wrote:
> 
> While reviewing another part of the code, Kees noticed that the
> strncpy of the partition name might not always be NUL terminated. Switch
> to using strscpy which does this safely.
> 
> Reported-by: Kees Cook <keescook@...omium.org>
> Signed-off-by: Laura Abbott <labbott@...hat.com>
> Reviewed-by: Kees Cook <keescook@...omium.org>
> ---
> v2: Switch to strscpy instead of just strlcpy
> ---
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Bryant G. Ly bly@...alogicsoftware.com

I sent a PR to update my email from bryantly@...ux.vnet.ibm.com a week ago.

-Bryant