linux-kernel - Re: [PATCH 1/3 v2] resource: fix an error which walks through iomem resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180920065935.GA11980@dhcp-128-65.nay.redhat.com>
Date:   Thu, 20 Sep 2018 14:59:35 +0800
From:   Dave Young <dyoung@...hat.com>
To:     lijiang <lijiang@...hat.com>
Cc:     Borislav Petkov <bp@...e.de>, linux-kernel@...r.kernel.org,
        kexec@...ts.infradead.org, tglx@...utronix.de, mingo@...hat.com,
        hpa@...or.com, x86@...nel.org, akpm@...ux-foundation.org,
        dan.j.williams@...el.com, thomas.lendacky@....com,
        bhelgaas@...gle.com, baiyaowei@...s.chinamobile.com, tiwai@...e.de,
        brijesh.singh@....com, Baoquan He <bhe@...hat.com>
Subject: Re: [PATCH 1/3 v2] resource: fix an error which walks through iomem
 resources

On 09/20/18 at 02:39pm, lijiang wrote:
> 在 2018年09月19日 21:29, Borislav Petkov 写道:
> > On Wed, Sep 19, 2018 at 08:52:49PM +0800, Lianbo Jiang wrote:
> > 
> > ...
> > 
> >> In fact, we should get the resource A and B when we walk through the
> >> whole tree, but it only gets the resource A, the resource B is missed.
> >>
> >> Signed-off-by: Dave Young <dyoung@...hat.com>
> >> Signed-off-by: Lianbo Jiang <lijiang@...hat.com>
> > 
> > Before looking at this: the SOB chain of all three patches is wrong.
> > Hint: see section 12) in Documentation/process/submitting-patches.rst
> > 
> Thanks for your advice, Borislav.
> 
> I have discussed with Dave Young, and he suggested that i might add a Suggested-by

patch 2 and patch 3 are based on my draft patch, but since you did debugging
and changes you can move my SOB to Suggested-by for patch 2 and patch 3,
for patch 1 please just drop my SOB and leave yours only. 


> tag instead of Signed-off-by tag for him. What do you think about?
> 
> I will modify the invalid SOB chain and post it again.
> 

Thanks
Dave