lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 20 Sep 2018 09:38:02 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Arend van Spriel <aspriel@...il.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Vivek Gautam <vivek.gautam@...eaurora.org>,
        Robin Murphy <robin.murphy@....com>,
        Joe Perches <joe@...ches.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Michal Hocko <mhocko@...e.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Jonathan Corbet <corbet@....net>, Roman Gushchin <guro@...com>,
        Huang Ying <ying.huang@...el.com>,
        Kees Cook <keescook@...omium.org>,
        Arnd Bergmann <arnd@...db.de>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v2 1/4] devres: constify p in devm_kfree()

On Tue 28 Aug 02:33 PDT 2018, Bartosz Golaszewski wrote:

> Make devm_kfree() signature uniform with that of kfree(). To avoid
> compiler warnings: cast p to (void *) when calling devres_destroy().
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> Signed-off-by: Bartosz Golaszewski <brgl@...ev.pl>
> ---
>  drivers/base/devres.c  | 5 +++--
>  include/linux/device.h | 2 +-
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/base/devres.c b/drivers/base/devres.c
> index f98a097e73f2..438c91a43508 100644
> --- a/drivers/base/devres.c
> +++ b/drivers/base/devres.c
> @@ -885,11 +885,12 @@ EXPORT_SYMBOL_GPL(devm_kasprintf);
>   *
>   * Free memory allocated with devm_kmalloc().
>   */
> -void devm_kfree(struct device *dev, void *p)
> +void devm_kfree(struct device *dev, const void *p)
>  {
>  	int rc;
>  
> -	rc = devres_destroy(dev, devm_kmalloc_release, devm_kmalloc_match, p);
> +	rc = devres_destroy(dev, devm_kmalloc_release,
> +			    devm_kmalloc_match, (void *)p);
>  	WARN_ON(rc);
>  }
>  EXPORT_SYMBOL_GPL(devm_kfree);
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 8f882549edee..33f7cb271fbb 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -692,7 +692,7 @@ static inline void *devm_kcalloc(struct device *dev,
>  {
>  	return devm_kmalloc_array(dev, n, size, flags | __GFP_ZERO);
>  }
> -extern void devm_kfree(struct device *dev, void *p);
> +extern void devm_kfree(struct device *dev, const void *p);
>  extern char *devm_kstrdup(struct device *dev, const char *s, gfp_t gfp) __malloc;
>  extern void *devm_kmemdup(struct device *dev, const void *src, size_t len,
>  			  gfp_t gfp);
> -- 
> 2.18.0
> 

Powered by blists - more mailing lists