linux-kernel - Re: [PATCH] decnet: Remove unnecessary check for dev->name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180921131856.0100018f@xeon-e3>
Date:   Fri, 21 Sep 2018 13:18:56 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        linux-decnet-user@...ts.sourceforge.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] decnet: Remove unnecessary check for dev->name

On Fri, 21 Sep 2018 12:30:34 -0700
Nathan Chancellor <natechancellor@...il.com> wrote:

> Clang warns that the address of a pointer will always evaluated as true
> in a boolean context.
> 
> net/decnet/dn_dev.c:1366:10: warning: address of array 'dev->name' will
> always evaluate to 'true' [-Wpointer-bool-conversion]
>                                 dev->name ? dev->name : "???",
>                                 ~~~~~^~~~ ~
> 1 warning generated.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/116
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Makes sense name in net_device is an array.

Reviewed-by: Stephen Hemminger <stephen@...workplumber.org>