linux-kernel - Re: [PATCH v2 00/12] crypto: caam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20180921054451.fkw4o4dwaqfuweyd@gondor.apana.org.au>
Date:   Fri, 21 Sep 2018 13:44:51 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Horia Geantă <horia.geanta@....com>
Cc:     Stuart Yoder <stuyoder@...il.com>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        Li Yang <leoyang.li@....com>, Roy Pledge <roy.pledge@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Aymen Sghaier <aymen.sghaier@....com>,
        linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 00/12] crypto: caam - add DPAA2 (DPSECI) driver

On Wed, Sep 12, 2018 at 11:59:25AM +0300, Horia Geantă wrote:
> Hi,
> 
> This patch set adds the CAAM crypto engine driver for DPAA2
> (Data Path Acceleration Architecture v2) found on ARMv8-based SoCs
> like LS1088A, LS2088A, LX2160A.
> 
> v1 -> v2:
> 5/12 - new patch fixing sparse endianness-related warnings
> 2/12 - changed commit message, since it's not a straightforward revert
> 3/12, 8/12, 11/12 - fixed sparse and compiler warnings
> 
> Previous versions:
> v1: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1763549.html
> RFC: https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg27290.html
> 
> Driver consists of:
> -DPSECI (Data Path SEC Interface) backend - low-level API that allows
> to manage DPSECI devices (DPAA2 objects) that sit on
> the Management Complex (MC) fsl-mc bus
> -algorithms frontend - AEAD, skcipher and ahash algorithms implementation
> 
> Patches 1-4 are fsl-mc bus and DPIO dependencies.
> Stuart, Laurentiu, Leo, Roy, please review the patches and let me know
> if you have anything against going with them through the cryptodev tree.
> 
> Patch 5 fixes sparse endianness-related warnings in regs.h helper functions.
> 
> Patches 6-11 are the core of the patch set, adding the driver.
> For symmetric encryption the new skcipher interface is used.
> 
> Patch 12 enables driver on arm64. It will be built only if dependency
> on DPIO (CONFIG_FSL_MC_DPIO) is satisfied.
> 
> Note: multiple modprobe/rmmod won't work without the following patches
> [5/7,v7] bus/fsl-mc: support dma configure for devices on fsl-mc bus
> https://patchwork.kernel.org/patch/10594179
> [7/7,v7] arm64: dts: ls208xa: comply with the iommu map binding for fsl_mc
> https://patchwork.kernel.org/patch/10594171
> (for LS1088A a similar DT update is needed)
> 
> Thanks,
> Horia
> 
> Horia Geantă (12):
>   bus: fsl-mc: add support for dpseci device type
>   soc: fsl: dpio: add back some frame queue functions
>   soc: fsl: dpio: add frame list format support
>   soc: fsl: dpio: add congestion notification support
>   crypto: caam - fix implicit casts in endianness helpers
>   crypto: caam - add DPAA2-CAAM (DPSECI) backend API
>   crypto: caam - add Queue Interface v2 error codes
>   crypto: caam/qi2 - add DPAA2-CAAM driver
>   crypto: caam/qi2 - add skcipher algorithms
>   crypto: caam - export ahash shared descriptor generation
>   crypto: caam/qi2 - add support for ahash algorithms
>   arm64: defconfig: enable CAAM crypto engine on QorIQ DPAA2 SoCs
> 
>  arch/arm64/configs/defconfig        |    1 +
>  drivers/bus/fsl-mc/fsl-mc-bus.c     |    5 +
>  drivers/crypto/Makefile             |    2 +-
>  drivers/crypto/caam/Kconfig         |   55 +-
>  drivers/crypto/caam/Makefile        |   10 +-
>  drivers/crypto/caam/caamalg_qi2.c   | 5165 +++++++++++++++++++++++++++++++++++
>  drivers/crypto/caam/caamalg_qi2.h   |  223 ++
>  drivers/crypto/caam/caamhash.c      |   79 +-
>  drivers/crypto/caam/caamhash_desc.c |   80 +
>  drivers/crypto/caam/caamhash_desc.h |   21 +
>  drivers/crypto/caam/compat.h        |    1 +
>  drivers/crypto/caam/dpseci.c        |  426 +++
>  drivers/crypto/caam/dpseci.h        |  333 +++
>  drivers/crypto/caam/dpseci_cmd.h    |  149 +
>  drivers/crypto/caam/error.c         |   79 +-
>  drivers/crypto/caam/error.h         |    6 +-
>  drivers/crypto/caam/regs.h          |   30 +-
>  drivers/soc/fsl/dpio/dpio-service.c |   58 +
>  include/linux/fsl/mc.h              |    6 +
>  include/soc/fsl/dpaa2-fd.h          |  242 ++
>  include/soc/fsl/dpaa2-global.h      |   15 +
>  include/soc/fsl/dpaa2-io.h          |    4 +
>  22 files changed, 6885 insertions(+), 105 deletions(-)
>  create mode 100644 drivers/crypto/caam/caamalg_qi2.c
>  create mode 100644 drivers/crypto/caam/caamalg_qi2.h
>  create mode 100644 drivers/crypto/caam/caamhash_desc.c
>  create mode 100644 drivers/crypto/caam/caamhash_desc.h
>  create mode 100644 drivers/crypto/caam/dpseci.c
>  create mode 100644 drivers/crypto/caam/dpseci.h
>  create mode 100644 drivers/crypto/caam/dpseci_cmd.h

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt