linux-kernel - RE: [PATCH] serial: imx: restore handshaking irq for imx1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB36009DCBD9F9F823EE216FF6FF120@VI1PR0402MB3600.eurprd04.prod.outlook.com>
Date:   Fri, 21 Sep 2018 01:18:25 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>
CC:     YueHaibing <yuehaibing@...wei.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Leonard Crestez <leonard.crestez@....com>
Subject: RE: [PATCH] serial: imx: restore handshaking irq for imx1

From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Sent: 2018年9月20日 20:11
> Back in 2015 when irda was dropped from the driver imx1 was broken.
> This change reintroduces the support for the third interrupt of the UART.
> 
> Fixes: afe9cbb1a6ad ("serial: imx: drop support for IRDA")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/tty/serial/imx.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index
> 4e853570ea80..554a69db1bca 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -2350,6 +2350,14 @@ static int imx_uart_probe(struct
> platform_device *pdev)
>  				ret);
>  			return ret;
>  		}
> +
> +		ret = devm_request_irq(&pdev->dev, rtsirq, imx_uart_rtsint, 0,
> +				       dev_name(&pdev->dev), sport);
> +		if (ret) {
> +			dev_err(&pdev->dev, "failed to request rts irq: %d\n",
> +				ret);
> +			return ret;
> +		}
>  	} else {
>  		ret = devm_request_irq(&pdev->dev, rxirq, imx_uart_int, 0,
>  				       dev_name(&pdev->dev), sport);
> --
> 2.18.0

Reviewed-by: Fugang Duan <fugang.duan@....com>