linux-kernel - Re: [PATCH 3.16 51/63] xfs: catch inode allocation state mismatch corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9017f05c55d2dd39f76f0a0e43c8ccbccdfaf9b4.camel@decadent.org.uk>
Date:   Sat, 22 Sep 2018 21:57:27 +0100
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Dave Chinner <dchinner@...hat.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        akpm@...ux-foundation.org,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        Carlos Maiolino <cmaiolino@...hat.com>
Subject: Re: [PATCH 3.16 51/63] xfs: catch inode allocation state mismatch
 corruption

On Sat, 2018-09-22 at 15:25 +1000, Dave Chinner wrote:
> On Sat, Sep 22, 2018 at 01:15:42AM +0100, Ben Hutchings wrote:
> > 3.16.58-rc1 review patch.  If anyone has any objections, please let
> > me know.
> > 
> > ------------------
> > 
> > From: Dave Chinner <dchinner@...hat.com>
> > 
> > commit ee457001ed6c6f31ddad69c24c1da8f377d8472d upstream.
> > 
> > We recently came across a V4 filesystem causing memory corruption
> > due to a newly allocated inode being setup twice and being added to
> > the superblock inode list twice. From code inspection, the only way
> > this could happen is if a newly allocated inode was not marked as
> > free on disk (i.e. di_mode wasn't zero).
> 
> ....
> > Signed-Off-By: Dave Chinner <dchinner@...hat.com>
> > Reviewed-by: Carlos Maiolino <cmaiolino@...hat.com>
> > Tested-by: Carlos Maiolino <cmaiolino@...hat.com>
> > Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>
> > Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> > [bwh: Backported to 3.16:
> >  - Look up mode in XFS inode, not VFS inode
> >  - Use positive error codes, and EIO instead of EFSCORRUPTED]
> 
> Why EIO?

I believe EIO was the usual error code used for filesystem errors
before EFSCORRUPTED was added.  But now I see xfs had its own private
definition of EFSCORRUPTED.  I'll change this back.

Ben.

-- 
Ben Hutchings
Any sufficiently advanced bug is indistinguishable from a feature.



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)