linux-kernel - Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d6f31c87b0c9b1a551d352439183c8c9c4df04c.camel@perches.com>
Date:   Mon, 24 Sep 2018 11:03:25 -0700
From:   Joe Perches <joe@...ches.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Bart Van Assche <bart.vanassche@....com>,
        Jason Gunthorpe <jgg@...lanox.com>,
        Sasha Levin <alexander.levin@...rosoft.com>
Subject: Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

On Mon, 2018-09-24 at 19:59 +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 24, 2018 at 09:38:26AM -0700, Joe Perches wrote:
> > On Mon, 2018-09-24 at 13:34 +0200, Greg Kroah-Hartman wrote:
> > > 3.18-stable review patch.  If anyone has any objections, please let me know.
> > 
> > Why should this sort of change be applied to a stable release?
> 
> Originally I was just going to drop this as it's not fixing something.
> 
> But it might be, if that macro is used in a if() statement, or something
> like that, it could be doing something unintended.

No it couldn't.
An empty macro is equivalent to a single statement.

> So I don't feel like auditing all 500+ instances where this is used,
> it's easier to just accept the patch.

It's not a bug fix.