linux-kernel - Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180924184010.GC9122@kroah.com>
Date:   Mon, 24 Sep 2018 20:40:10 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Joe Perches <joe@...ches.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Bart Van Assche <bart.vanassche@....com>,
        Jason Gunthorpe <jgg@...lanox.com>,
        Sasha Levin <alexander.levin@...rosoft.com>
Subject: Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning

On Mon, Sep 24, 2018 at 11:03:25AM -0700, Joe Perches wrote:
> On Mon, 2018-09-24 at 19:59 +0200, Greg Kroah-Hartman wrote:
> > On Mon, Sep 24, 2018 at 09:38:26AM -0700, Joe Perches wrote:
> > > On Mon, 2018-09-24 at 13:34 +0200, Greg Kroah-Hartman wrote:
> > > > 3.18-stable review patch.  If anyone has any objections, please let me know.
> > > 
> > > Why should this sort of change be applied to a stable release?
> > 
> > Originally I was just going to drop this as it's not fixing something.
> > 
> > But it might be, if that macro is used in a if() statement, or something
> > like that, it could be doing something unintended.
> 
> No it couldn't.
> An empty macro is equivalent to a single statement.

{sigh}  It's been a long few weeks...

Yes, you are right, I was forgetting the trailing ;

Ok, I'll go drop this now, thanks.

greg k-h