linux-kernel - Re: [PATCH] powerpc/traps: merge unrecoverable_exception() and nonrecoverable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875zyu5pr6.fsf@concordia.ellerman.id.au>
Date:   Tue, 25 Sep 2018 11:29:01 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Christophe Leroy <christophe.leroy@....fr>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] powerpc/traps: merge unrecoverable_exception() and nonrecoverable_exception()

Christophe Leroy <christophe.leroy@....fr> writes:

> diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
> index 6ab66a88db14..4567eeb6524e 100644
> --- a/arch/powerpc/kernel/traps.c
> +++ b/arch/powerpc/kernel/traps.c
> @@ -2090,8 +2082,9 @@ void SPEFloatingPointRoundException(struct pt_regs *regs)
>   */
>  void unrecoverable_exception(struct pt_regs *regs)
>  {
> -	printk(KERN_EMERG "Unrecoverable exception %lx at %lx\n",
> -	       regs->trap, regs->nip);
> +	pr_emerg("Unrecoverable exception %lx at %lx (msr=%lx)\n",
> +		 regs->trap, regs->nip, regs->msr);
> +	debugger(regs);
>  	die("Unrecoverable exception", regs, SIGABRT);

die() already calls debugger() if the trap is != 0x100.

I don't think we want to call it twice?

cheers