linux-kernel - Re: [PATCH] powerpc/traps: merge unrecoverable_exception() and nonrecoverable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af93f6f7-b7e7-64a0-b9df-4f1721a567bd@c-s.fr>
Date:   Tue, 25 Sep 2018 06:43:55 +0200
From:   Christophe LEROY <christophe.leroy@....fr>
To:     Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] powerpc/traps: merge unrecoverable_exception() and
 nonrecoverable_exception()



Le 25/09/2018 à 03:29, Michael Ellerman a écrit :
> Christophe Leroy <christophe.leroy@....fr> writes:
> 
>> diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
>> index 6ab66a88db14..4567eeb6524e 100644
>> --- a/arch/powerpc/kernel/traps.c
>> +++ b/arch/powerpc/kernel/traps.c
>> @@ -2090,8 +2082,9 @@ void SPEFloatingPointRoundException(struct pt_regs *regs)
>>    */
>>   void unrecoverable_exception(struct pt_regs *regs)
>>   {
>> -	printk(KERN_EMERG "Unrecoverable exception %lx at %lx\n",
>> -	       regs->trap, regs->nip);
>> +	pr_emerg("Unrecoverable exception %lx at %lx (msr=%lx)\n",
>> +		 regs->trap, regs->nip, regs->msr);
>> +	debugger(regs);
>>   	die("Unrecoverable exception", regs, SIGABRT);
> 
> die() already calls debugger() if the trap is != 0x100.
> 
> I don't think we want to call it twice?

Oh, good spot. So nonrecoverable_exception() is calling it twice.

I'll fix the patch. Thanks.

Christophe