linux-kernel - Re: [PATCH net 3/7] lan78xx: Check for supported Wake-on-LAN modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f791e4b6-7493-b54b-a88f-47d0ef4a3409@gmail.com>
Date:   Tue, 25 Sep 2018 10:26:25 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Woojung.Huh@...rochip.com, netdev@...r.kernel.org
Cc:     davem@...emloft.net, UNGLinuxDriver@...rochip.com,
        steve.glendinning@...well.net, keescook@...omium.org,
        akurz@...la.de, hayeswang@...ltek.com, kai.heng.feng@...onical.com,
        grundler@...omium.org, zhongjiang@...wei.com,
        bigeasy@...utronix.de, ran.wang_1@....com, edumazet@...gle.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 3/7] lan78xx: Check for supported Wake-on-LAN modes

On 09/25/2018 10:19 AM, Woojung.Huh@...rochip.com wrote:
> Hi Florian,
> 
>> @@ -1415,6 +1415,9 @@ static int lan78xx_set_wol(struct net_device *netdev,
>>  	if (wol->wolopts & WAKE_ARP)
>>  		pdata->wol |= WAKE_ARP;
>>
>> +	if (pdata->wol == 0)
>> +		return -EINVAL;
>> +
> It will make function return when disabling WOL.

Huh, yes, good point.

> Is there other place handling this scenario?

How do you mean?

> 
>>  	device_set_wakeup_enable(&dev->udev->dev, (bool)wol->wolopts);
>>
>>  	phy_ethtool_set_wol(netdev->phydev, wol);
> 
> 
> Thanks.
> Woojung
> 


-- 
Florian